diff options
author | Hans de Goede <hdegoede@redhat.com> | 2021-11-25 21:30:10 +0100 |
---|---|---|
committer | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2021-11-25 23:38:04 +0200 |
commit | bdfd6ab8fdccd8b138837efff66f4a1911496378 (patch) | |
tree | 422cc0f46d414fb15c14b290d0d6505f9e122d65 /tools/perf/scripts/python/exported-sql-viewer.py | |
parent | 2ff64a84bbb3ea0281899766d9a944fd18db7013 (diff) | |
download | linux-bdfd6ab8fdccd8b138837efff66f4a1911496378.tar.gz linux-bdfd6ab8fdccd8b138837efff66f4a1911496378.tar.bz2 linux-bdfd6ab8fdccd8b138837efff66f4a1911496378.zip |
gpiolib: acpi: Do not set the IRQ type if the IRQ is already in use
If the IRQ is already in use, then acpi_dev_gpio_irq_get_by() really
should not change the type underneath the current owner.
I specifically hit an issue with this an a Chuwi Hi8 Super (CWI509) Bay
Trail tablet, when the Boot OS selection in the BIOS is set to Android.
In this case _STA for a MAX17047 ACPI I2C device wrongly returns 0xf and
the _CRS resources for this device include a GpioInt pointing to a GPIO
already in use by an _AEI handler, with a different type then specified
in the _CRS for the MAX17047 device. Leading to the acpi_dev_gpio_irq_get()
call done by the i2c-core-acpi.c code changing the type breaking the
_AEI handler.
Now this clearly is a bug in the DSDT of this tablet (in Android mode),
but in general calling irq_set_irq_type() on an IRQ which already is
in use seems like a bad idea.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions