diff options
| author | Benjamin Poirier <bpoirier@suse.com> | 2017-05-17 16:24:13 -0400 |
|---|---|---|
| committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2017-06-06 01:05:13 -0700 |
| commit | 24ad2a9209a0bf1ec37fac25a011c98551865abb (patch) | |
| tree | 276930cbdf2187fbfb9779871c3ac6b651d66fe3 /net/switchdev/switchdev.c | |
| parent | 81e3f64a9b2d837717a58606d9f22420a47fdf68 (diff) | |
| download | linux-24ad2a9209a0bf1ec37fac25a011c98551865abb.tar.gz linux-24ad2a9209a0bf1ec37fac25a011c98551865abb.tar.bz2 linux-24ad2a9209a0bf1ec37fac25a011c98551865abb.zip | |
e1000e: Don't return uninitialized stats
Some statistics passed to ethtool are garbage because e1000e_get_stats64()
doesn't write them, for example: tx_heartbeat_errors. This leaks kernel
memory to userspace and confuses users.
Do like ixgbe and use dev_get_stats() which first zeroes out
rtnl_link_stats64.
Fixes: 5944701df90d ("net: remove useless memset's in drivers get_stats64")
Reported-by: Stefan Priebe <s.priebe@profihost.ag>
Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'net/switchdev/switchdev.c')
0 files changed, 0 insertions, 0 deletions