aboutsummaryrefslogtreecommitdiff
path: root/net/ipv4/tcp_output.c
diff options
context:
space:
mode:
authorVladimir Oltean <vladimir.oltean@nxp.com>2024-10-08 12:43:20 +0300
committerJakub Kicinski <kuba@kernel.org>2024-10-09 19:41:35 -0700
commit8c924369cb56c3054dca504c2c9c3eb208272865 (patch)
treeda3623bb8f5ae2c71b1d0bfc439006ee61fd3f4b /net/ipv4/tcp_output.c
parent6be063071a457767ee229db13f019c2ec03bfe44 (diff)
downloadlinux-8c924369cb56c3054dca504c2c9c3eb208272865.tar.gz
linux-8c924369cb56c3054dca504c2c9c3eb208272865.tar.bz2
linux-8c924369cb56c3054dca504c2c9c3eb208272865.zip
net: dsa: refuse cross-chip mirroring operations
In case of a tc mirred action from one switch to another, the behavior is not correct. We simply tell the source switch driver to program a mirroring entry towards mirror->to_local_port = to_dp->index, but it is not even guaranteed that the to_dp belongs to the same switch as dp. For proper cross-chip support, we would need to go through the cross-chip notifier layer in switch.c, program the entry on cascade ports, and introduce new, explicit API for cross-chip mirroring, given that intermediary switches should have introspection into the DSA tags passed through the cascade port (and not just program a port mirror on the entire cascade port). None of that exists today. Reject what is not implemented so that user space is not misled into thinking it works. Fixes: f50f212749e8 ("net: dsa: Add plumbing for port mirroring") Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://patch.msgid.link/20241008094320.3340980-1-vladimir.oltean@nxp.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/ipv4/tcp_output.c')
0 files changed, 0 insertions, 0 deletions