diff options
| author | David S. Miller <davem@davemloft.net> | 2023-06-12 11:32:45 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-06-12 11:32:45 +0100 |
| commit | f2f069da4c40dcf136db731c9fece17c3bbf7cdc (patch) | |
| tree | 4d86ba36fb3a24593be237c151aad15439d1bea8 /net/ethtool/netlink.c | |
| parent | 238131684f7b1bc2e0788583f22ed67bf3f5ca37 (diff) | |
| parent | 500e1340d1d2695de3f15fc0b3781f593a77acc2 (diff) | |
| download | linux-f2f069da4c40dcf136db731c9fece17c3bbf7cdc.tar.gz linux-f2f069da4c40dcf136db731c9fece17c3bbf7cdc.tar.bz2 linux-f2f069da4c40dcf136db731c9fece17c3bbf7cdc.zip | |
Merge branch 'ethtool-extack'
Jakub Kicinski says:
====================
net: support extack in dump and simplify ethtool uAPI
Ethtool currently requires header nest to be always present even if
it doesn't have to carry any attr for a given request. This inflicts
unnecessary pain on the users.
What makes it worse is that extack was not working in dump's ->start()
callback. Address both of those issues.
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ethtool/netlink.c')
| -rw-r--r-- | net/ethtool/netlink.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c index 08120095cc68..5dd5e8222c45 100644 --- a/net/ethtool/netlink.c +++ b/net/ethtool/netlink.c @@ -96,6 +96,8 @@ int ethnl_parse_header_dev_get(struct ethnl_req_info *req_info, int ret; if (!header) { + if (!require_dev) + return 0; NL_SET_ERR_MSG(extack, "request header missing"); return -EINVAL; } |