diff options
| author | Sergey Ryazanov <ryazanov.s.a@gmail.com> | 2021-12-07 12:21:38 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-12-08 17:58:58 -0800 |
| commit | 13b94fbaa28c64cebee5fcd43a9b5971e8591497 (patch) | |
| tree | 65e0f75ad88a696581a30ac8e7d4d5ce2808ceda /drivers/net/wwan/iosm/iosm_ipc_trace.c | |
| parent | e9877d4ef856c7e8c66e942baa94dd0dde09b787 (diff) | |
| download | linux-13b94fbaa28c64cebee5fcd43a9b5971e8591497.tar.gz linux-13b94fbaa28c64cebee5fcd43a9b5971e8591497.tar.bz2 linux-13b94fbaa28c64cebee5fcd43a9b5971e8591497.zip | |
net: wwan: iosm: allow trace port be uninitialized
Collecting modem firmware traces is optional for the regular modem use.
There are not many reasons for aborting device initialization due to an
inability to initialize the trace port and (or) its debugfs interface.
So, demote the initialization failure erro message into a warning and do
not break the initialization sequence in this case. Rework packet
processing and deinitialization so that they do not crash in case of
uninitialized trace port.
This change is mainly a preparation for an upcoming configuration option
introduction that will help disable driver debugfs functionality.
Signed-off-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
Acked-by: M Chetan Kumar <m.chetan.kumar@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/wwan/iosm/iosm_ipc_trace.c')
| -rw-r--r-- | drivers/net/wwan/iosm/iosm_ipc_trace.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/wwan/iosm/iosm_ipc_trace.c b/drivers/net/wwan/iosm/iosm_ipc_trace.c index 5f5cfd39bede..c588a394cd94 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_trace.c +++ b/drivers/net/wwan/iosm/iosm_ipc_trace.c @@ -172,6 +172,9 @@ struct iosm_trace *ipc_trace_init(struct iosm_imem *ipc_imem) */ void ipc_trace_deinit(struct iosm_trace *ipc_trace) { + if (!ipc_trace) + return; + debugfs_remove(ipc_trace->ctrl_file); relay_close(ipc_trace->ipc_rchan); mutex_destroy(&ipc_trace->trc_mutex); |