diff options
| author | Eric Dumazet <edumazet@google.com> | 2024-06-04 18:15:11 +0000 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-06-05 15:54:51 -0700 |
| commit | f921a58ae20852d188f70842431ce6519c4fdc36 (patch) | |
| tree | 3c29a9ff0867da88895c4abcc490b0c2f6d600c9 /drivers/net/ethernet/intel/ice/ice_main.c | |
| parent | 229bedbf62b13af5aba6525ad10b62ad38d9ccb5 (diff) | |
| download | linux-f921a58ae20852d188f70842431ce6519c4fdc36.tar.gz linux-f921a58ae20852d188f70842431ce6519c4fdc36.tar.bz2 linux-f921a58ae20852d188f70842431ce6519c4fdc36.zip | |
net/sched: taprio: always validate TCA_TAPRIO_ATTR_PRIOMAP
If one TCA_TAPRIO_ATTR_PRIOMAP attribute has been provided,
taprio_parse_mqprio_opt() must validate it, or userspace
can inject arbitrary data to the kernel, the second time
taprio_change() is called.
First call (with valid attributes) sets dev->num_tc
to a non zero value.
Second call (with arbitrary mqprio attributes)
returns early from taprio_parse_mqprio_opt()
and bad things can happen.
Fixes: a3d43c0d56f1 ("taprio: Add support adding an admin schedule")
Reported-by: Noam Rathaus <noamr@ssd-disclosure.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20240604181511.769870-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/intel/ice/ice_main.c')
0 files changed, 0 insertions, 0 deletions