aboutsummaryrefslogtreecommitdiff
path: root/drivers/net/ethernet/intel/ice/ice_main.c
diff options
context:
space:
mode:
authorKonstantin Shkolnyy <kshk@linux.ibm.com>2024-12-03 09:06:54 -0600
committerPaolo Abeni <pabeni@redhat.com>2024-12-05 11:39:33 +0100
commit7ce1c0921a806ee7d4bb24f74a3b30c89fc5fb39 (patch)
treed9f3b853c69cba7d34bd8b3b4a973ecc72731637 /drivers/net/ethernet/intel/ice/ice_main.c
parent4615855ea8c42aff76cc7772509445dc80bcd917 (diff)
downloadlinux-7ce1c0921a806ee7d4bb24f74a3b30c89fc5fb39.tar.gz
linux-7ce1c0921a806ee7d4bb24f74a3b30c89fc5fb39.tar.bz2
linux-7ce1c0921a806ee7d4bb24f74a3b30c89fc5fb39.zip
vsock/test: fix failures due to wrong SO_RCVLOWAT parameter
This happens on 64-bit big-endian machines. SO_RCVLOWAT requires an int parameter. However, instead of int, the test uses unsigned long in one place and size_t in another. Both are 8 bytes long on 64-bit machines. The kernel, having received the 8 bytes, doesn't test for the exact size of the parameter, it only cares that it's >= sizeof(int), and casts the 4 lower-addressed bytes to an int, which, on a big-endian machine, contains 0. 0 doesn't trigger an error, SO_RCVLOWAT returns with success and the socket stays with the default SO_RCVLOWAT = 1, which results in vsock_test failures, while vsock_perf doesn't even notice that it's failed to change it. Fixes: b1346338fbae ("vsock_test: POLLIN + SO_RCVLOWAT test") Fixes: 542e893fbadc ("vsock/test: two tests to check credit update logic") Fixes: 8abbffd27ced ("test/vsock: vsock_perf utility") Signed-off-by: Konstantin Shkolnyy <kshk@linux.ibm.com> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/net/ethernet/intel/ice/ice_main.c')
0 files changed, 0 insertions, 0 deletions