aboutsummaryrefslogtreecommitdiff
path: root/drivers/fpga/microchip-spi.c
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2024-08-06 22:14:07 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2024-10-07 13:34:41 -0400
commit1d3b4bec3ce55e0c46cdce7d0402dbd6b4af3a3d (patch)
treeeecf8973805e3b17b6b55cf95189b97e1cf5822b /drivers/fpga/microchip-spi.c
parent0c40bf47cf2d9e1413b1e62826c89c2341e66e40 (diff)
downloadlinux-1d3b4bec3ce55e0c46cdce7d0402dbd6b4af3a3d.tar.gz
linux-1d3b4bec3ce55e0c46cdce7d0402dbd6b4af3a3d.tar.bz2
linux-1d3b4bec3ce55e0c46cdce7d0402dbd6b4af3a3d.zip
alloc_fdtable(): change calling conventions.
First of all, tell it how many slots do we want, not which slot is wanted. It makes one caller (dup_fd()) more straightforward and doesn't harm another (expand_fdtable()). Furthermore, make it return ERR_PTR() on failure rather than returning NULL. Simplifies the callers. Simplify the size calculation, while we are at it - note that we always have slots_wanted greater than BITS_PER_LONG. What the rules boil down to is * use the smallest power of two large enough to give us that many slots * on 32bit skip 64 and 128 - the minimal capacity we want there is 256 slots (i.e. 1Kb fd array). * on 64bit don't skip anything, the minimal capacity is 128 - and we'll never be asked for 64 or less. 128 slots means 1Kb fd array, again. * on 128bit, if that ever happens, don't skip anything - we'll never be asked for 128 or less, so the fd array allocation will be at least 2Kb. Reviewed-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'drivers/fpga/microchip-spi.c')
0 files changed, 0 insertions, 0 deletions