diff options
| author | Shenghao Ding <shenghao-ding@ti.com> | 2024-12-11 12:38:59 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2024-12-11 13:27:45 +0000 |
| commit | 2aa13da97e2b92d20a8ad4ead10da89f880b64e7 (patch) | |
| tree | df31b8f8ba045d72a11d97332bbb6b37cedc0631 /drivers/cdx/controller/cdx_controller.c | |
| parent | 687630aa582acf674120c87350beb01d836c837c (diff) | |
| download | linux-2aa13da97e2b92d20a8ad4ead10da89f880b64e7.tar.gz linux-2aa13da97e2b92d20a8ad4ead10da89f880b64e7.tar.bz2 linux-2aa13da97e2b92d20a8ad4ead10da89f880b64e7.zip | |
ASoC: tas2781: Fix calibration issue in stress test
One specific test condition: the default registers of p[j].reg ~
p[j+3].reg are 0, TASDEVICE_REG(0x00, 0x14, 0x38)(PLT_FLAG_REG),
TASDEVICE_REG(0x00, 0x14, 0x40)(SINEGAIN_REG), and
TASDEVICE_REG(0x00, 0x14, 0x44)(SINEGAIN2_REG). After first calibration,
they are freshed to TASDEVICE_REG(0x00, 0x1a, 0x20), TASDEVICE_REG(0x00,
0x16, 0x58)(PLT_FLAG_REG), TASDEVICE_REG(0x00, 0x14, 0x44)(SINEGAIN_REG),
and TASDEVICE_REG(0x00, 0x16, 0x64)(SINEGAIN2_REG) via "Calibration Start"
kcontrol. In second calibration, the p[j].reg ~ p[j+3].reg have already
become tas2781_cali_start_reg. However, p[j+2].reg, TASDEVICE_REG(0x00,
0x14, 0x44)(SINEGAIN_REG), will be freshed to TASDEVICE_REG(0x00, 0x16,
0x64), which is the third register in the input params of the kcontrol.
This is why only first calibration can work, the second-time, third-time
or more-time calibration always failed without reboot. Of course, if no
p[j].reg is in the list of tas2781_cali_start_reg, this stress test can
work well.
Fixes: 49e2e353fb0d ("ASoC: tas2781: Add Calibration Kcontrols for Chromebook")
Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
Link: https://patch.msgid.link/20241211043859.1328-1-shenghao-ding@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/cdx/controller/cdx_controller.c')
0 files changed, 0 insertions, 0 deletions