From b0923d5d80facb205cc2b7f82994ab5c3eef3181 Mon Sep 17 00:00:00 2001 From: Sunil Khatri Date: Thu, 2 May 2024 14:18:08 +0530 Subject: drm/amdgpu: remove ip dump reg_count variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit reg_count is not used and the register count is directly derived from the array size and hence removed. Signed-off-by: Sunil Khatri Acked-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 1 - 1 file changed, 1 deletion(-) (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h') diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h index 64f197bbc866..9a946f0e015c 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h @@ -436,7 +436,6 @@ struct amdgpu_gfx { /* IP reg dump */ uint32_t *ip_dump; - uint32_t reg_count; }; struct amdgpu_gfx_ras_reg_entry { -- cgit From 68de5d31b15b4c923da4c8b7df7d4046139f9f80 Mon Sep 17 00:00:00 2001 From: Jesse Zhang Date: Wed, 8 May 2024 18:14:13 +0800 Subject: drm/amdgpu: remove structurally dead code This code cannot be reached: return "UNKNOWN";. Signed-off-by: Jesse Zhang Reviewed-by: Tim Huang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h') diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h index 9a946f0e015c..109f471ff315 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h @@ -554,8 +554,6 @@ static inline const char *amdgpu_gfx_compute_mode_desc(int mode) default: return "UNKNOWN"; } - - return "UNKNOWN"; } #endif -- cgit From 74feef5667ef326122054d11257b2a2e1098dac0 Mon Sep 17 00:00:00 2001 From: Sunil Khatri Date: Tue, 7 May 2024 11:08:34 +0530 Subject: drm/amdgpu: rename the ip_dump to ip_dump_core Rename the memory pointer from ip_dump to ip_dump_core to make it specific to core registers and rest other registers to be dumped in their respective memories. Reviewed-by: Alex Deucher Signed-off-by: Sunil Khatri Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h') diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h index 109f471ff315..a28462643b00 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h @@ -435,7 +435,7 @@ struct amdgpu_gfx { bool mcbp; /* mid command buffer preemption */ /* IP reg dump */ - uint32_t *ip_dump; + uint32_t *ip_dump_core; }; struct amdgpu_gfx_ras_reg_entry { -- cgit From 0f83227bc8f09da9a11cbbdfdaa9d724f83086f4 Mon Sep 17 00:00:00 2001 From: Sunil Khatri Date: Wed, 22 May 2024 10:43:22 +0530 Subject: drm/amdgpu: Add cp queues support fro gfx10 in ipdump Add support to dump registers of all instances of cp queue registers of gfx10 to devcoredump. Reviewed-by: Alex Deucher Signed-off-by: Sunil Khatri Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h') diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h index a28462643b00..77ab5d0fd592 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h @@ -436,6 +436,7 @@ struct amdgpu_gfx { /* IP reg dump */ uint32_t *ip_dump_core; + uint32_t *ip_dump_cp_queues; }; struct amdgpu_gfx_ras_reg_entry { -- cgit From 8444453dced3e5d81a1ca0368fc6227834b9eb8f Mon Sep 17 00:00:00 2001 From: Sunil Khatri Date: Wed, 22 May 2024 10:54:17 +0530 Subject: drm/amdgpu: add gfx queue support of gfx10 in ipdump Add gfx queue register for all instances in devcoredump for gfx10. Reviewed-by: Alex Deucher Signed-off-by: Sunil Khatri Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h') diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h index 77ab5d0fd592..a9d9f372a7c1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h @@ -437,6 +437,7 @@ struct amdgpu_gfx { /* IP reg dump */ uint32_t *ip_dump_core; uint32_t *ip_dump_cp_queues; + uint32_t *ip_dump_gfx_queues; }; struct amdgpu_gfx_ras_reg_entry { -- cgit From 33837d62a4cb5ef316dec4fada5c1012ddbc0239 Mon Sep 17 00:00:00 2001 From: Sunil Khatri Date: Fri, 31 May 2024 12:22:20 +0530 Subject: drm/amdgpu: rename ip_dump_cp_queues to compute queues Rename the variable ip_dump_cp_queues to ip_dump_compute_queue as it represent compute queues. Reviewed-by: Alex Deucher Signed-off-by: Sunil Khatri Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h') diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h index a9d9f372a7c1..6b0416777c5b 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h @@ -436,7 +436,7 @@ struct amdgpu_gfx { /* IP reg dump */ uint32_t *ip_dump_core; - uint32_t *ip_dump_cp_queues; + uint32_t *ip_dump_compute_queues; uint32_t *ip_dump_gfx_queues; }; -- cgit